build: remove redundant -fuse-linker-plugin from GCC LTO flags#62667
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Apr 13, 2026
Merged
Conversation
The `-fuse-linker-plugin` flag has been automatically enabled by GCC since version 5 when LTO is active, making the explicit flag redundant. Since Node.js requires GCC >= 13.2, this flag serves no purpose. Removing it also improves portability with alternative linkers (mold, lld) that may not support GCC's linker plugin interface, avoiding build failures when these linkers are used with GCC LTO builds. Refs: yao-pkg/pkg#231 Signed-off-by: Daniel Lando <daniel.sorridi@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
11 tasks
richardlau
approved these changes
Apr 10, 2026
github-actions
bot
removed
the
request-ci
Collaborator
targos
approved these changes
Apr 13, 2026
Contributor
Author
|
Am I supposed to do something for the broken test or is it just flaky? |
Member
|
It's probably flaky. I rerun it. |
richardlau
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 91d83c3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
-fuse-linker-pluginflag has been automatically enabled by GCCsince version 5 when LTO is active, making the explicit flag
redundant. Since Node.js requires GCC >= 13.2, this flag serves no
purpose.
Removing it also improves portability with alternative linkers (mold,
lld) that may not support GCC's linker plugin interface, avoiding
build failures when these linkers are used with GCC LTO builds.
Refs: yao-pkg/pkg#231